As an applicant, I'd like to know what my First and Last name character limitations are so that there are no errors with my application when accepted to suds.

ASprinkle commented 4 years ago

Notes

This is similar to #411 (long organizational name)

In this case however, an application should not be allowed to be submitted when the First and Last name characters exceed the acceptable allowable character limit for SUDS.

Acceptance Criteria

[x] Applicants are notified of a character limit for First and Last Name if they reach the threshold.
[x] Applicants are not able to submit applications with First and Last Names that exceed the acceptable number of characters.

Tasks

[x] Verify First and Last name character limitations in SUDS
[x] Build code to restrict the Character Limit for First Name to 36 characters or Less including spaces.
[x] Build code to restrict the Character Limit for the Last Name to 60 characters or Less including spaces.
[x] Add Validation message for the First Name box: "The First Name must be less than 36 characters."
[x] Add Validation message for the Last Name box: "The Last Name must be less than 60 characters."
[x] Validation shows red border indicating error on first name box if contents exceed the limit.
[x] Validation shows red border indicating error on last name box if contents exceed the limit.
[x] Validation shows red exclamation mark in the left nav. menu if the error still exists in the application. Validation shows green check mark when no errors.
[x] PO approved

Definition of Done

[x] Pull requests meet technical definition of done
[ ] Usability tested by dev

ASprinkle commented 4 years ago

Character Limits for SUDS per the FSH 2709.11 Chapter 60 The limit in SUDS is 60 Characters including spaces. This means that in Open Forest there should be a limit of 30 in the First Name field and 30 in the last name field as an even split.

ASprinkle commented 4 years ago

@Dmac26 In reviewing this story, it looks like the updates are working well for the non-commercial group use and for Christmas tree pages. However it appears, when reviewing the code, that we still need to make the update to the Outfitter Guide application sections. I'll move this back to in progress for now. I included some screen shots here for reference. Thanks!

https://github.com/USDAForestService/fs-open-forest-platform/blob/dev/frontend/src/app/application-forms/temporary-outfitters/temporary-outfitters.component.ts

ASprinkle commented 4 years ago

TOG name field validations are looking good

mtlaney commented 4 years ago

blocked by #1196

USDAForestService / fs-open-forest-platform