As a developer, I would like to be able to work locally without hitting s3

USDAForestService / fs-open-forest-platform

Open Forest: The code for an online permitting platform for the U.S. Forest Service.

https://openforest.fs.usda.gov

Other

38 stars 19 forks source link

As a developer, I would like to be able to work locally without hitting s3 #196

Open hannahkane opened 6 years ago

hannahkane commented 6 years ago

Notes

Acceptance Criteria

[x] Set up local minio server
[x] Figure out configuration to point to it

Tasks

Definition of Done

[ ] Code unit / e2e tested and comply with QWASP
[ ] No new security vulnerabilities
[ ] Internal team code review
[ ] Documentation / readme.md / CircleCI updated
[ ] Docker updated
[ ] Compare finished design with mockup
[ ] Usability tested

tadhg-ohiggins commented 6 years ago

Status: I have local development working in the fs-middlelayer-api minio branch, and had both local and local Docker development working, but could not determine what broke the latter after merging the dev branch. Given that @lauraGgit mocked out the S3 tests in JavaScript, this isn't as needed, and the combination of how much time getting it to work with Docker had taken me and the unknown time required to get past whatever the current problem has led to deprioritizing this for the moment.

Note that all the work for this was done on https://github.com/18F/fs-middlelayer-api as that's where the S3 communication is.

lauraGgit commented 6 years ago

@msadakFS this can likely be archived.

davemcorwin commented 5 years ago

I'd like to revisit this issue. This is currently a blocker when developing the platform locally as we can't QA test anything that involves file uploads. The solution does NOT require running minio and should only require

[ ] using "DiskStorage" or "MemoryStorage" options for multer instead of "S3"
[ ] using mock-aws to mock getObject to pull from wherever multer stores the files.