As a tempoutfitter organization, I should be able to submit my application without receiving an organization error.

lauraGgit commented 6 years ago

Notes

specific bug on org types: need to update the following placess to allow for list below:

Frontend

https://github.com/18F/fs-permit-platform/blob/dev/frontend/src/app/application-forms/fields/org-type.component.html

https://github.com/18F/fs-permit-platform/blob/dev/frontend/src/app/application-forms/fields/org-type.component.html#L27 Value to "Limited Liability Company"

https://github.com/18F/fs-permit-platform/blob/dev/frontend/src/app/application-forms/fields/org-type.component.html#L31 Value to "Limited Partnership"

https://github.com/18F/fs-permit-platform/blob/dev/frontend/src/app/application-forms/fields/org-type.component.html#L35 Value to "State Govt"

Local Govt and Corporation are correct

https://github.com/18F/fs-permit-platform/blob/dev/frontend/src/app/application-forms/fields/org-type.component.html#L43 Value to "Non Profit Org"

Server

Update this: https://github.com/18F/fs-permit-platform/blob/dev/server/src/controllers/temp-outfitter.es6#L323

Middlelayer

https://github.com/18F/fs-middlelayer-api/blob/master/src/controllers/translate.json#L45 update to:

                            "Association",
                            "Corporation",
                            "Educational and Research",
                            "Federal Govt",
                            "State Govt",
                            "Local Govt",
                            "Married Common Property",
                            "Limited Liability Company",
                            "Limited Partnership",
                            "Person",
                            "Trust"

https://github.com/18F/fs-middlelayer-api/blob/master/src/controllers/translate.json#L279

Acceptance Criteria

[ ] a temp outfitter org application is accepted to suds

Tasks

[x] update validation on frontend
[x] update repopulation for applications on hold in frontend
[x] update server validation in temp-outfitter controller
[x] update middlelayer translate.json

Definition of Done

[x] Code unit / e2e tested and comply with QWASP
[x] Server actions captured by logs
[x] No new security vulnerabilities
[x] Internal team code review
[x] Documentation / readme.md / CircleCI updated
[x] Docker updated
[x] Compare finished design with mockup
[x] Usability tested

tadhg-ohiggins commented 6 years ago

If the user marks themselves as an applicant type other than individual, SUDS considers the organization name field to be required, but the form currently treats it as optional, leading to errors during SUDS submission.

hursey013 commented 6 years ago

@msadakFS Right now when a someone submits a form with an organization type other than Individual, theBusiness name (optional)field is actually required. The problem with the current layout is thatBusiness name (optional)` is the third field from the top of the form and by the time a user reaches the organization type section they have long since scrolled passed that field so there is no way to indicate that it is now required.

Would it make sense to move the Business name (optional) field down to the organization type section and only display it if something other than Individual is selected, therefore removing the "optional" aspect of it?

msadakFS commented 6 years ago

@hursey013 That sounds good

hursey013 commented 6 years ago

@msadakFS Would it be better to use Organization name instead of Business namesince it won't always apply to Partnership or association, State Government or Agency, Local Government or Agency, and Nonprofit?

msadakFS commented 6 years ago

@hursey013 Yes, organization name is more scalable

hursey013 commented 6 years ago

from @lauraGgit, we need to make sure its consistent with the existing PRA approved form - we may need to leave it as it is in order to not deviate from the approved form.

msadakFS commented 6 years ago

@hursey013 @hannahkane Can we change Business Name to Organization Name so it matches the notification?

hannahkane commented 6 years ago

Agreed the field label and error message should be consistent. I can't tell from the thread above which is correct. What does the existing PRA-approved form use?

lauraGgit commented 6 years ago

The PRA form says "Business Name": http://www.fs.usda.gov/Internet/FSE_DOCUMENTS/stelprdb5251858.docx

msadakFS commented 6 years ago

Should the title change based on applicant type? Business Name, Agency Name, Organization Name, etc.

lauraGgit commented 6 years ago

We are constrained by the Paperwork Reduction Act, and cannot change it conditionally as it has to match the existing paper form.

On Wed, Jul 18, 2018 at 9:50 AM, Marcus Sadak notifications@github.com wrote:

Should the title change based on applicant type? Business Name, Agency Name, Organization Name, etc.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/18F/fs-permit-platform/issues/249#issuecomment-405980167, or mute the thread https://github.com/notifications/unsubscribe-auth/AFkgXSkWTgREo4jxYQVXHZSChOkWvIKmks5uH1k4gaJpZM4U_ZhM .

-- Laura Gerhardt 18F acquisition | GSA | 202-257-7082

msadakFS commented 6 years ago

I would recommend changing the "Organization name is required" to "Business name is required" to match

USDAForestService / fs-open-forest-platform