USDepartmentofLabor / Child-Labor

25 stars 16 forks source link

Preliminary Accessibility and QA Testing of iPhone Findings #18

Closed jfc3-dol closed 7 years ago

jfc3-dol commented 9 years ago

New ILAB iPhone Application Issues

QA team started doing preliminary testing of the new ILAB iPhone application.

We have listed the issues by screen and if it is an accessibility issue, recommendation for usability improvement, question, etc. We still need to test the application with VoiceOver (iPhone screen reader).

Home Screen

Image of exploitation screen

It becomes much harder to see that the symbols on top of them are even separate entities.

I will tinker with making them a shade darker, perhaps 5%, and see if that helps their own visibility without obscuring the exploitation symbols. But in general, for the intended use cases of this screen, it’s not a priority that the user necessarily be able to visually identify every good. The most important use of this screen is to see which countries have the most goods and what types of exploitation dominate. Thus, I’m reluctant to increase the recognizability of the individual goods at the expense of the exploitation types attached to each.

Now as you complete correcting the issues listed above you can check them off, and we can test them again to see if that is correct. If something is out of scope you can add "OUT OF SCOPE" after the check box. It would be helpful to add the date the update was made to the beginning of the issue, so we know which ones were updated when.

jfc3-dol commented 9 years ago

Has any progress been made on this issue, since there are only a few more weeks before this project is to be completed.?

skeeJay commented 9 years ago

I've been out of the country and just returned to the office today. The plan is to resolve all open issues by early next week and get the app to you for final QA at that time, with an eye towards submission to the App Store 4–5 days later.

Today I will triage/answer the bullets noted in this ticket and either respond to each or open a new ticket to correct.

jfc3-dol commented 9 years ago

Thanks, for the update. If it makes sense to create other issues to keep track of thing that is fine. I will use our issue to keep tabs on what items have been completed.

No need to respond to my e-mail, which was only sent because I wasn't sure if you had seen this earlier or not.

skeeJay commented 9 years ago

Thanks, @jfc3-dol . I will create a separate issue for each bug we'll fix, yes. This will allow me to link each code commit to the bug it fixes in Github.

However, I'll note preliminarily that many of the issues here refer to standardized iOS controls. For example, elements of a table view such as disclosure indicators (">"), the section ("ABC…") index on the right, item separator lines, and section headings inside of a table view are provided for by the operating system—we haven't controlled the display, size, or color of any of these elements. Apple has designed these to be reusable and standardized across all iOS applications for recognizability and accessibility, and it's generally considered bad to customize or recreate standardized controls. I will note the items that this applies to in my triage.

skeeJay commented 9 years ago

@jfc3-dol , I’ve commented on all of these issues inline in the comment above. Many have been corrected in the new beta you’ll receive this week. Many others are comments on interface elements controlled by the operating system, which aren’t in our control. These are elements that Apple standardizes, including for accessibility purposes, so we can’t and shouldn’t mess with them. A couple referred to external websites which aren't part of this app, so I marked those "OUT OF SCOPE".

I’ve marked the other recommendations about design and will run them by the ILAB team at our weekly meeting this week. Anything we decided to update based on these recommendations are changes I can make with any other bugs the “official” testing uncovers later in the week.

The other accessibility issues I created tickets to correct:

Thanks very much, @jfc3-dol .

jfc3-dol commented 9 years ago

For now added a few comments about the PDF's being accessible might not be a project issue, but ILAB should fix those either way.

Once I get the newest application update from Joey I will go through these and check off the ones that have been corrected, along with adding a date when they were fixed of considered out of scope.

jfc3-dol commented 9 years ago

While looking at the latest version of the Child Labor iPhone application I found the following issues:

I have checked the issues that have been corrected and added a note in bold. Some have the date I did the review of 09/09/2015 and some have additional comments if I don't think Apple is correct with their defaults for things.

We need to do a review of the application with VoiceOver either later today or in the morning (09/10/2015), but figured I would up date what I could above along with the Fact Sheet issue above..

jfc3-dol commented 9 years ago

New ILAB Child Labor iPhone Application Accessibility Issues (VoiceOver)

Here are the accessibility issues I have found so far with the new ILAB Child Labor iPhone application. I will add any other items I find in another comment later today.

Home Screen

More Info Screen

Countries – A – Z - Screen

Individual Countries Screen

jfc3-dol commented 9 years ago

More Child Labor iPhone Application Accessibility Issues (VoiceOver)

About this App Screen

Methodology Screen

Fact Sheet Screens (Reports, OFCT, and Programs)

Countries – By Level - Screen

Countries – By Region - Screen

Individual Countries Screen

Individual Countries - Suggested Actions - Screen

Individual Countries – Statistics - Screen

Individual Countries – International Conventions - Screen

Individual Countries – Legal Standards - Screen

Goods – A – Z - Screen

Goods – By Sector – Screen

Individual Goods Screen

Exploitation Type Screen

spoonstein commented 9 years ago

@jfc3-dol you can't setup iOS screens like you can HTML. So there isn't a h1, h2, h3 kind of layering. Do you have something that reflects accessibility for iOS? This is what I see: https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/iPhoneAccessibility/Accessibility_on_iPhone/Accessibility_on_iPhone.html#//apple_ref/doc/uid/TP40008785-CH100-SW1

jfc3-dol commented 9 years ago

There are screens in this application that have different heading levels such as the "About this App" under the more information section.

skeeJay commented 9 years ago

A small number of text-only screens in the app, "About this App" and "Methodology," are web views, meaning they contain HTML content and do indeed have HTML elements. But all other screens use native iOS controls such as label views and table views (defined at https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/Bars.html#//apple_ref/doc/uid/TP40006556-CH12-SW1), and HTML elements aren't applicable in them.

jfc3-dol commented 9 years ago

Okay.

Have never read about or built an iOS application so was trying to use terminology I understand from the website side of things.

In a few cases/screens, I think we still need to add a heading here and there to make it easier to navigate the application.

jfc3-dol commented 9 years ago

@skeeJay are you making any progress with all the open accessibility, usability, and VoiceOver issues? If not are they going to be worked on while Apple is reviewing the application since most if not all of them need to be fixed before the release or very soon after? If DOL is doing to put the application out with these outstanding issues, we (OPA DEC) will need someone in ILAB taking responsibility for any open issues.

jfc3-dol commented 7 years ago

Closing this issue because a lot has changed in the last two years and some might not apply and other could be fixed.

Closing issue.