search

USDepartmentofLabor / Ilab-do-good

ILab Do Good
0 stars 3 forks source link

Functional - iOS - Spanish - Not All Text on Search Results Page is Spanish #116

Closed jfc3-dol closed 6 years ago

jfc3-dol commented 6 years ago

While testing that VoiceOver was reading the correct languages, I tested the search function. Looking at the screen while listening to the Spanish I noticed that the word "Search Results" and "X results found for XYZ" where in English instead of Spanish.

See screenshot below of what I'm referring too.

cc - spanish - search results

ghost commented 6 years ago

Fixed in the commit made at 7.15pm on 8/7/18

jfc3-dol commented 6 years ago

Because I couldn't get my iOS devices updated yet, I looked at them on the website, and the word has been translated into Spanish.

Will close once I see them updated on the iOS devices.

jfc3-dol commented 6 years ago

For some reason after @giridhar rebuilt the iOS for me only it still is showing the English words as in the image above.

jfc3-dol commented 6 years ago

The iOS version is missing the breadcrumb and search page text and what is the first line under the header section is in English and not Spanish.

See the screenshots below.

Web - Spanish - Search page - All words are in Spanish

complychain - web - spanish - search - all words are in spanish

iOS - Spanish - Search page - Some words are in English

complychain - ios - spanish - search - some words are in english and missing one line below header section

ghost commented 6 years ago

fixed in the latest push on 8/18

jfc3-dol commented 6 years ago

All the text on the search results screen is in Spanish as expected.

Closing issue.