search

USDepartmentofLabor / Ilab-do-good

ILab Do Good
0 stars 3 forks source link

Accessibility - Web - Pages Missing Language #91

Closed jfc3-dol closed 6 years ago

jfc3-dol commented 6 years ago

In the web pages, there is not even a default language set for the pages which should be English (lang="en"). By not having a language set or the wrong one will cause issues for screen reader users. Say I'm a Spanish speaking user and I come to your page that doesn't have language set. JAWS will read your English words with a Spanish accent really fast.

When a person changes languages to either Spanish or French, the pages should be set to that language for all pages in the application until the person switches to something else. Which most likely won't happen ever again for others or often, but because I'm testing all the languages mine should keep changing.

So no Spanish or French accents for the proper pages. VoiceOver is reading "2 / 8" as "two slash eight" on the Spanish page instead of "dos barras ocho" or "deux slash huit" for the French page. Please note my translations came from Google translate. So please get any other messages in the application appropriately translated.

ghost commented 6 years ago

fixed

jfc3-dol commented 6 years ago

Nice start by adding a language set to the pages, but no matter which language you have picked the language of the page is English ( lang="en" ).

ghost commented 6 years ago

Can you check to see if you have the latest version of code downloaded? I pushed another fix today morning.
When I changed to French and inspected the page I found it to correctly display lang='fr'. Is this what you are referring to ?

capture

jfc3-dol commented 6 years ago

I will have to check with @giridhar and see which version he used. Thought he grabbed the newest version, but he could have copied the one you told him to last week in case you were making changes that would break things at this point.

My language is set to English on all the pages I checked not matter which one the content was set too.

jfc3-dol commented 6 years ago

DEVTOOLS inspect shows the correct language but when I "View Source" it's in English.

Will check with a screen reader to see what language the page is read in but have an issue that I can only look at WEB pages in Chrome and my screen reader works best in IE or Firefox.

See the screenshot below.

complychain - web - spanish - but view source shows english

ghost commented 6 years ago

Yeah the source has lang set to "en" for default purposes but if the language is changed or if the language is not English, then the lang is dynamically changed using JavaScript to match the correct language ... it should behave properly in Screen Readers but the source file will still show lang as 'en'

jfc3-dol commented 6 years ago

Thanks, @sanganalakshay will give it a test with my screen reader if I can since JAWS doesn't work so well with Chrome. For some reason with the latest update, I can't use IE or Firefox to view any of the pages which will make testing difficult because my tools are in those browsers.

jfc3-dol commented 6 years ago

When I used VoiceOver on my iPad, it read in the proper language that I had chosen. Once the newest build gets deployed and I can use JAWS on IE or Firefox I will close this issue if it to works which I'm expecting it to do so.

jfc3-dol commented 6 years ago

JAWS is reading the English, Spanish, and French pages as expected on IE 11.

I'm going to close this issue.