search

USEPA / CompTox-ToxCast-tcplFit2

A Concentration-Response Modeling Utility
https://usepa.github.io/CompTox-ToxCast-tcplFit2/
Other
1 stars 0 forks source link

23 address technical review feedback part 2 #24

Closed brown-jason closed 1 year ago

brown-jason commented 1 year ago

Made a few minor changes from Grace

brown-jason commented 1 year ago

@sedavid01 plotting in general needs a major overhaul. I think we can add this to future work or even pawn off plotting to tcpl in the futuer where we've had more significant work.

sedavid01 commented 1 year ago

@brown-jason - Now that I think about it... I originally processed the comment as figure captions NOT figure legends, so that is where I got hung up. Thank you for your response. I agree we can move plotting updates to future scope.

I think there is likely good context for the figures in the vignette for now - so we can take or leave updating figure captions in the vignette. Though if we don't add them this round we definitely should prioritize this with future development of the vignettes in tcplfit2.

Please let me know your thoughts @brown-jason, if you want figure captions or just push all figure updates to future scope. Thanks!

brown-jason commented 1 year ago

@sedavid01 I think we've addressed the technical reviewers at this point so lets push it to future scope

sedavid01 commented 1 year ago

@sedavid01 I think we've addressed the technical reviewers at this point so lets push it to future scope

Okay sounds good. Thanks, @brown-jason.