search

USEPA / CompTox-ToxCast-tcplFit2

A Concentration-Response Modeling Utility
https://usepa.github.io/CompTox-ToxCast-tcplFit2/
Other
1 stars 0 forks source link

83 errfun should default to dt4 if not provided to tcplhit2 core #84

Closed gracezhihuizhao closed 7 months ago

gracezhihuizhao commented 7 months ago

'errfun' is required in tcplhit2_core. Adding a check for if this parameter is provided in params / output from tcplfit2_core. If the function should throw an error.

cthunes commented 7 months ago

It may be useful to either change warning() to error() to abort before running into another error, or to throw warning() and also set errfun to default "dt4" errfun <- "dt4". What do you guys think?

sedavid01 commented 7 months ago

It may be useful to either change warning() to error() to abort before running into another error, or to throw warning() and also set errfun to default "dt4" errfun <- "dt4". What do you guys think?

Ahhh, good catch. Yes, this should throw an error rather than a warning.

cthunes commented 7 months ago

It threw an appropriate error when I didn't include the necessary parameter and when I did, I was able to process successfully. Thanks!

sedavid01 commented 7 months ago

Approved and verified with 'tcpl' package team. Going to go ahead and merge these updates into 'dev'.