USEPA / EPATADA

This R package can be used to compile and evaluate Water Quality Portal (WQP) data for samples collected from surface water monitoring sites on streams and lakes. It can be used to create applications that support water quality programs and help states, tribes, and other stakeholders efficiently analyze the data.
https://usepa.github.io/EPATADA/
Creative Commons Zero v1.0 Universal
39 stars 18 forks source link

Remove unit conversions from TADA Harmonization Template #398

Closed cristinamullin closed 4 months ago

cristinamullin commented 7 months ago

Is your feature request related to a problem? Please describe.

hillarymarler commented 5 months ago

@cristinamullin

I'm working on removing units from the harmonization template. Without units, there is one TADA.CharacteristicName that has two rows where TADA.CharacteristicName/TADA.ResultSampleFractionText,/TADA.MethodSpeciationName are the same. Is it possible to select just one of these to keep in the Harmonization Template?

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

  | TADA.CharacteristicName | Target.TADA.CharacteristicName | TADA.CharacteristicNameAssumptions | TADA.ResultSampleFractionText | Target.TADA.ResultSampleFractionText | TADA.FractionAssumptions | TADA.MethodSpeciationName | Target.TADA.MethodSpeciationName | TADA.SpeciationAssumptions | Target.TADA.SpeciationConversionFactor | HarmonizationGroup | CountN -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --   |   |   |   |   |   |   |   |   |   |   |   |   1 | TOTAL NITROGEN, MIXED FORMS | NA | NA | NA | NA | NA | AS N | NA | NA | NA | Nitrogen | 2 2 | TOTAL NITROGEN, MIXED FORMS | NA | NA | NA | UNFILTERED | Assumes TOTAL KJELDAHL NITROGEN (ORGANIC N & NH3), NONE is synonymous to TOTAL KJELDAHL NITROGEN (ORGANIC N & NH3), UNFILTERED. | AS N | NA | NA | NA | Nitrogen | 2

cristinamullin commented 5 months ago

Yes good catch, you can remove the top line.

From: hillarymarler @.> Sent: Thursday, April 11, 2024 3:07 PM To: USEPA/TADA @.> Cc: Mullin, Cristina (she/her/hers) @.>; Mention @.> Subject: Re: [USEPA/TADA] Remove unit conversions from TADA Harmonization Template (Issue #398)

Caution: This email originated from outside EPA, please exercise additional caution when deciding whether to open attachments or click on provided links.

@cristinamullinhttps://github.com/cristinamullin

I'm working on removing units from the harmonization template. Without units, there is one TADA.CharacteristicName that has two rows where TADA.CharacteristicName/TADA.ResultSampleFractionText,/TADA.MethodSpeciationName are the same. Is it possible to select just one of these to keep in the Harmonization Template?

TADA.CharacteristicName Target.TADA.CharacteristicName TADA.CharacteristicNameAssumptions TADA.ResultSampleFractionText Target.TADA.ResultSampleFractionText TADA.FractionAssumptions TADA.MethodSpeciationName Target.TADA.MethodSpeciationName TADA.SpeciationAssumptions Target.TADA.SpeciationConversionFactor HarmonizationGroup CountN

1 TOTAL NITROGEN, MIXED FORMS NA NA NA NA NA AS N NA NA NA Nitrogen 2 2 TOTAL NITROGEN, MIXED FORMS NA NA NA UNFILTERED Assumes TOTAL KJELDAHL NITROGEN (ORGANIC N & NH3), NONE is synonymous to TOTAL KJELDAHL NITROGEN (ORGANIC N & NH3), UNFILTERED. AS N NA NA NA Nitrogen 2

- Reply to this email directly, view it on GitHubhttps://github.com/USEPA/TADA/issues/398#issuecomment-2050337060, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALGLGYCIF3NBHJ3EXP4UWPDY43NNPAVCNFSM6AAAAABDFMTBNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGMZTOMBWGA. You are receiving this because you were mentioned.Message ID: @.**@.>>