search

USEPA / EPATADA

This R package can be used to compile and evaluate Water Quality Portal (WQP) data for samples collected from surface water monitoring sites on streams and lakes. It can be used to create applications that support water quality programs and help states, tribes, and other stakeholders efficiently analyze the data.
https://usepa.github.io/EPATADA/
Creative Commons Zero v1.0 Universal
39 stars 18 forks source link

Monitoring location QAQC #446

Closed cristinamullin closed 3 months ago

cristinamullin commented 4 months ago

Is your feature request related to a problem? Please describe.

TADA_FindNearbySites() TADA_FlagCoordinates()

We have two functions to assist with monitoring location QAQC. One flags nearby sites that may be the same site (same area monitored by multiple orgs or the same org submitted data for the same area multiple times with different monitoring location ID's). The other flags imprecise coordinates and coordinates outside of the US.

Describe the solution you'd like

Users have requested to be able to review the sites on a map before removing them. This may be an R Shiny only feature, but let's explore how we might facilitate this in the R package, potentially using TADA_OverviewMap().

This issue is closely tied with an existing Shiny issue: https://github.com/USEPA/TADAShiny/issues/136 It also ties in with this issue: https://github.com/USEPA/TADA/issues/292

We also have a mock up for this, see:

pages 4-6: https://usepa.sharepoint.com/sites/WQPDataAssessmentTeam/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2FWQPDataAssessmentTeam%2FShared%20Documents%2FGeneral%2FTADA%20Dev%2FRShiny%2FTADA%20Module%201%20Mockups%2002252022%2Epdf&viewid=deb12f0b%2D3d2c%2D4694%2Dbe22%2D7d262f785cce&parent=%2Fsites%2FWQPDataAssessmentTeam%2FShared%20Documents%2FGeneral%2FTADA%20Dev%2FRShiny slide 5: https://usepa.sharepoint.com/:p:/r/sites/WQPDataAssessmentTeam/_layouts/15/Doc.aspx?sourcedoc=%7BD09286FA-0BB1-452B-9920-913CE3C9D772%7D&file=Tool%201%20Mock%20Ups.pptx&action=edit&mobileredirect=true

hillarymarler commented 4 months ago

I'm interested in helping with this one if it is still in need of additional development after I finish working on vignettes for upcoming presentations.

cristinamullin commented 4 months ago

Adding relevant note from Erik Leppo below (TADA Working Group follow up email):

I ran across an article today that described some packages that did similar cleaning of coordinates albeit some for a specific purpose. But a number of the tests the package runs might be useful (missing, outside of study area, 0/0, at sea, political unit centroids, spatial outliers, conversion errors).

Here is the article: https://www.r-bloggers.com/2023/01/safe-and-simple-cleaning-of-species-occurrences/

The list of checks is here: https://ropensci.github.io/CoordinateCleaner/reference/index.html

The vignettes with good demos are here: https://ropensci.github.io/CoordinateCleaner/articles/Cleaning_GBIF_data_with_CoordinateCleaner.html https://ropensci.github.io/CoordinateCleaner/index.html

You may have already investigated the existing packages out there for coordinate and other data cleaning and this is old news for you. But if not then this is my small contribution to the project. The package seems to only do coordinate cleaning and is on CRAN (and ropensci) so it should stay supported and not get orphaned.

cristinamullin commented 3 months ago

This issue is being addressed elsewhere: https://github.com/USEPA/TADA/issues/464 and https://github.com/USEPA/TADA/issues/474