USEPA / EPATADA

This R package can be used to compile and evaluate Water Quality Portal (WQP) data for samples collected from surface water monitoring sites on streams and lakes. It can be used to create applications that support water quality programs and help states, tribes, and other stakeholders efficiently analyze the data.
https://usepa.github.io/EPATADA/
Creative Commons Zero v1.0 Universal
39 stars 18 forks source link

pH harmonization issues #454

Open hillarymarler opened 2 months ago

hillarymarler commented 2 months ago

After TADA_UnitConversion and TADA_HarmonizeSynonyms, pH results from some data sets are being grouped into multiple TADA.ComparableDataIdentifiers.

A data set that can be used to see this is:

data <- TADA_DataRetrieval(statecode = "IL", startDate = "2010-01-01", endDate = "2020-12-31", huc = c("0714010505", "0714010504", "0714010508", "0714010501", "0714010503"), characteristicType = "Physical", applyautoclean = TRUE)

image

Ideally, all of these pH results would be identified with the same TADA.ComparableDataIdentifier.

To solve this we could edit the metadata for pH entries using the harmonization table (we can specify that fraction is not needed for PH in the assumptions/notes column). All of these should harmonize to PH_NA_NA_NONE.

hillarymarler commented 2 months ago

Potential similar issues observed with total nitrogen in same example data set.

hillarymarler commented 3 weeks ago

I think other characteristics in the "Physical" characteristic type group should be reviewed as well.