Figures.r condensed code and tada view color palette to return a non null value

USEPA / EPATADA

This R package can be used to compile and evaluate Water Quality Portal (WQP) data for samples collected from surface water monitoring sites on streams and lakes. It can be used to create applications that support water quality programs and help states, tribes, and other stakeholders efficiently analyze the data.

https://usepa.github.io/EPATADA/

Creative Commons Zero v1.0 Universal

40 stars 18 forks source link

Figures.r condensed code and tada view color palette to return a non null value #511

Closed wokenny13 closed 2 months ago

wokenny13 commented 3 months ago

Created a for loop for TADA_GroupedScatter to condense the code and make it more concise. Will work to edit other functions like TADA_DepthProfilePlot to see if this can be done there

TADA_ViewColorPalette() should also return a stored value in the example documentations now rather than return NULL or an empty list().

wokenny13 commented 3 months ago

Waiting to see if checks go through successfully. Once it is successful, checking a few other examples to make sure the TADA_GroupedScatterplot is still functioning would be good to do.

wokenny13 commented 2 months ago

The changes to the grouped scatterplot are excellent- code is much more concise and it functions as intended.

For viewing the color palette, the updates work for the original palette, but I get this error when I run it for the pairs:

This happens when it run it with or without assigning it a name.

Thanks for finding this! I will look into it to determine what may be the cause

hillarymarler commented 2 months ago

I'm still seeing the same error when I try to assign a name with col_pair = TRUE.

wokenny13 commented 2 months ago

It seems like that error may show up depending on the screen margin of the monitor it is being viewed on. On my second monitor I don't get any error messages, but when I switch RStudio to the laptop monitor screen, I do run into an error.

But when I do re-run TADA_ViewColorPalette(col_pair = TRUE) again on the laptop monitor screen, I am able to view it, but it shows up looking like this:

Rather than looking like this on my 2nd monitor:

What does your plot look like when you run TADA_ViewColorPalette(col_pair = TRUE)?

I will try to see if I can find a solution by adjusting the figure margins to be compatible when viewed on any monitor

hillarymarler commented 2 months ago

This is a tricky one!

On my laptop monitor I get this error:

I have two other monitors. One of them it works, on the other one, I get this error message: