search

USEPA / EPA_Non-geo_Metadata_Editor

3 stars 0 forks source link

Handling files with multiple records #79

Closed jzichichi closed 5 years ago

jzichichi commented 5 years ago

@torrin47, the current implementation allows user to load file with more than one record in it. User is able to edit first record; other content is saved but not shown to user in the edit interface, but it is shown when the view the raw json content to be saved. What happens if user submits this type of record to EPA? Will this cause problems or confusion?

torrin47 commented 5 years ago

It probably would reduce confusion for the submission to include only the first record until the editor allows editing of multiple records. If the submission only went to the EDG team I wouldn't worry about it, but because we're planning on also sending the submission to the EPA sponsor for review and approval, I think it needs to be limited to the first record.

aergul commented 5 years ago

Only metadata for first dataset included in submission now.

jzichichi commented 5 years ago

@aergul - saves first record only for both submission and save functions? I tested with a pre-existing OLEM record and it worked great - retaining only first record - but for both save and submit. Guessing that's intentional. Wanted to be sure.

aergul commented 5 years ago

The intention is to keep all for save but submit only the first. If that's not the case then it is a bug.

jzichichi commented 5 years ago

@aergul - OK I thought I had remembered discussing it that way. It seems to me save chops it off. See attached files. OSWER-EF is the original and the second is the saved (with some edits from the editor in there).

Maybe there is an issue with the formatting in the original - it's one that was handed to me a few months ago and I was editing it via notepad - the records contained in it were accepted by EDG..

E3C724A0-A2DB-4B43-BC07-A7A2B5671E2F.txt OSWER-EF.txt

aergul commented 5 years ago

@jzichichi while submit and save operated on a copy of the document rather than the original, they both operated on the same copy. Now we use a fresh copy sans datasets other than first during submission.

jzichichi commented 5 years ago

@aergul BETTER!!! Moving over for @torrin47 to review

torrin47 commented 5 years ago

Is great, thanks!