EPA Grant Punchlist - Githubissues

USEPA / EPA_Non-geo_Metadata_Editor

3 stars 0 forks source link

Closed torrin47 closed 5 years ago

torrin47 commented 5 years ago

Pending final decision, we need to:

Change name to EPA Agreement
make value mandatory
Add picklist allowing user to specify agreement type: Grant, Contract, Cooperative Agreement, Inter-Agency Agreement, or other.

aergul commented 5 years ago

The element we used before (epa_grant_no) is now replaced with epa_agreement_type and epa_agreement_no. FYI.

Ready for QA.

jzichichi commented 5 years ago

@aergul - this looks good to me. Moving over for @torrin47 to review

torrin47 commented 5 years ago

Looks great, would just like to request a tiny tweak. Could we change the wording to:

"Please select EPA agreement type" and "Please enter EPA agreement number or description"

aergul commented 5 years ago

Wording tweaked

jzichichi commented 5 years ago

@aergul @torrin47 - wording updates look correct to me.

torrin47 commented 5 years ago

Great.