USEPA / ElectricityLCI

Creative Commons Zero v1.0 Universal
24 stars 10 forks source link

Use of print statements within methods #186

Closed dt-woods closed 1 year ago

dt-woods commented 2 years ago

For some reason, there is a strange and pervasive use of both print statements and logging statements throughout the modules in eLCI. From an end-user application standpoint, print statements should not be used within function calls with the exception of a setup script (debatable) or a method that explicitly requests it (e.g., print_values()) and may just be remnants from the development process. The inclusion of print statements slows down runtimes due to the relatively long time it takes to write data to the console and obscures logging statement streams.

Please consider removing the over-abundance of print statements. If you wish to maintain communication with users, may I suggest that these print statements be replaced with info-level (or other) logging statements.