USEPA / ElectricityLCI

Creative Commons Zero v1.0 Universal
24 stars 10 forks source link

Forced BA aggregation for FERC and US, but what about eGRID? #222

Open dt-woods opened 6 months ago

dt-woods commented 6 months ago

In ELCI_3, the aggregation level is set to eGRID. In preparation for the consumption and distribution mixes, the in-line comment says that aggregation should be made at the BA level if it is set to FERC or US. What about NERC and eGRID?

https://github.com/USEPA/ElectricityLCI/blob/e56268132f7607ead58a33bb5bdd525563a784f5/electricitylci/main.py#L59

dt-woods commented 6 months ago

I raise this issue because, for some reason, the generation mix doesn't have the 'Generation_ratio' column when testing ELCI_3, which crashes the olcaschema_gen_mix that requires that column.

m-jamieson commented 5 months ago

I was going to recommend ignoring ECLI_3 for now, but are you doing this as part of testing to make sure the "2016" inventory still works?

ELCI_3 is dependent on the write aggregation to be set per below. I guess we could probably do a bit more to handle things automatically if EPA_eGRID_trading: True. Is that what you're looking for?

https://github.com/USEPA/ElectricityLCI/blob/master/electricitylci/modelconfig/ELCI_3_config.yml#15

Not sure why this line wouldn't be creating the Generation_Ratio: https://github.com/USEPA/ElectricityLCI/blob/2232c41f2cb4fd333ad59c8710aa55906e6a7ed3/electricitylci/generation_mix.py#L291

dt-woods commented 5 months ago

Thanks, Matt. If/when I run across this error again, I'll post it here. But, for now, I'm going to skip ELCI_3 model tests and focus on 2020 model config. Did you get a chance to confirm the configuration settings? If not, please see here.