search

USEPA / ElectricityLCI

Creative Commons Zero v1.0 Universal
24 stars 10 forks source link

Update upstream metadata #92

Closed bl-young closed 4 years ago

bl-young commented 4 years ago

-Updated upstream processes to show correct years for start date and end date -Fixed typos -Set default target year to the electricity_lci_target_year

bl-young commented 4 years ago

@jump2conclusionsmatt Please double check. Given comments on metadata for the upstream systems, wanted to make sure they were consistent with eLCI; so updated metadata for coal, gas, and oil to reflect 2016 as the data year.

Also removed two old metadata files to avoid confusion.

bl-young commented 4 years ago

The changes I made were causing an exception? No i wasn't having any issues. Re: current year, I'm not sure I completely track how that year variable is used, given that the generation and emissions data is running from 2016 in most cases from eGRID, right?

m-jamieson commented 4 years ago

Oh I see, these didn't exist before: ar["validUntil"] = "12/31/"+targetyear - they were just statically set to 2018. I looked at the commits out of order I guess.

Yeah, most everything is tied to 2016, and 2018 used to be relevant. I guess we'll just keep it for now, but it's a bit weird. I'm just not sure how to update it. Should it be whatever year the user chooses for that target date?

m-jamieson commented 4 years ago

And it didn't show 2016 because I never actually fetched your branch I guess. Anyhow, everything seems to be working. Reviewed and approved!