USEPA / R9-CentralBasin

0 stars 2 forks source link

Mb/53 - Add ground transparency slider to basemap gallery widget #103

Closed MatteoBerg closed 1 year ago

MatteoBerg commented 2 years ago

This PR resolves #53, adding the ability to adjust basemap/ground transparency which will allow users to view objects underground.

I imitated styling of the ground transparency slider in the Central Basin 3D Scene - v1.3 beta scene shown here:

image

Here is a demo showing the added functionality matching the above example scene:

basemap-transparency.webm

tbock commented 1 year ago

It looks like you are not setting the slider to the current value of the basemap's transparency when it loads. Can you confirm/fix @MatteoBerg

MatteoBerg commented 1 year ago

Fix slider start value

Changed slider start value from 1 to map.ground.opacity value when slider is created.

tbock commented 1 year ago

Slider is wrong after selecting a slide then opening the base map gallery again. The slider is still at old value not the value of the current ground opacity. @MatteoBerg

MatteoBerg commented 1 year ago

Feature is included in branch mb/47, PR #104