search

USEPA / SWMM-EPANET_User_Interface

User interface for the Stormwater-Management-Model
112 stars 67 forks source link

SWMM project defaults don't handle metric units #238

Closed barrc closed 4 years ago

barrc commented 6 years ago

If your project is in metric units, should get the value associated with the metric default. Issue #173 also addresses differences between the default values and the values listed in the user's manual.

PaulDudaRESPEC commented 5 years ago

Upon closer examination, this issue is an enhancement, not a bug. The behavior of the new UI is the same as it was in the older SWMM UI, and it is assumed that the default values provided are in the unit system being used.

barrc commented 5 years ago

I think in the old UI, if you change the unit system, different values are populated for a few of the parameters on the Dynamic Wave tab of the Simulation Options. But I don't recall if there are any other differences based on unit system, so it's correct to label the broad statement I initially posted as an enhancement.

US units: image

Metric units: image

dickinsonre commented 5 years ago

Yes, that is true @barrc but it is the current GUI you are describing or the Delphi Pascal UI. Labels and defaults change based on the units of the model.

barrc commented 5 years ago

@dickinsonre are you saying the labels and defaults change based on the units of the model in the current UI or the Delphi UI? It sounds like Paul was saying the labels/defaults don't change in the Delphi UI. I might be confused here.

PaulDudaRESPEC commented 5 years ago

@barrc Yes, now we see where there are differences in the default values for a few of the dynamic wave settings; thanks for pointing that out -- we'll be sure to fix those. In most instances the labels in the new UI change depending on the units system, but we see there are some of those that need to be fixed too.

PaulDudaRESPEC commented 5 years ago

OK, fixed the dynamic wave options so that the labels and defaults change appropriately.

PaulDudaRESPEC commented 5 years ago

Found other instances where the labels were not changing appropriately on the climatology tabs, those are now fixed. All labeling now switches back and forth from english to metric appropriately.

barrc commented 4 years ago

I think this can be closed now; the labels switch back and forth and the behavior is consistent with the Delphi GUI. We can always revisit later.