USEPA / SWMM-EPANET_User_Interface

User interface for the Stormwater-Management-Model
111 stars 67 forks source link

SWMM LID control editor - pollutant removal tab #322

Closed barrc closed 4 years ago

barrc commented 4 years ago

I see Pollutant Removals was added as a tab in the LID control editor but I'm wondering if that was intentional? I don't see a tab for that in the Delphi GUI and it doesn't seem like you can enter anything there.

Version: MTP6r1

dickinsonre commented 4 years ago

Pollutant removal in an LID was added by Lew Rossman for EPA SWMM 5.1.013 You see it in the Delphi Gui for some LID's if you have a pollutant. image

barrc commented 4 years ago

@dickinsonre thank you for pointing that out! I think the editor needs to be tweaked slightly but I"ll look at how the Delphi GUI works and be more specific.

PaulDudaRESPEC commented 4 years ago

@barrc Have you had a chance to compare this editor to the Delphi version as you mentioned? Perhaps you can do more testing here and see if you still see tweaks needed, otherwise this issue could be closed.

barrc commented 4 years ago

@PaulDudaRESPEC thanks for the reminder, this issue fell off my radar. I will take a look this afternoon and either update or close.

barrc commented 4 years ago

In the Delphi GUI if there is no pollutant defined, the LID control editor looks like this for BR: image

vs in the new UI: image

I can take a look at disabling the tab (similar to the way the Pavement tab is disabled for BR) if there is no pollutant defined in the project and see if I can figure it out.