search

USEPA / SWMM-EPANET_User_Interface

User interface for the Stormwater-Management-Model
111 stars 66 forks source link

Only set selected item if items exist #346

Closed barrc closed 4 years ago

barrc commented 4 years ago

Towards #345

With this change the UI still lets a user click "OK" if they haven't selected any non-existent subcatchments, which causes the UI to crash. So maybe we need another commit that addresses that or we can do a follow-up PR.

barrc commented 4 years ago

@PaulDudaRESPEC your check works for subcatchments but it seems like it makes it so you can't get a system report since there is nothing to select.

PaulDudaRESPEC commented 4 years ago

Oops, I overlooked that! I’ll fix it…

From: Colleen Barr notifications@github.com Sent: Wednesday, January 29, 2020 12:08 PM To: USEPA/SWMM-EPANET_User_Interface SWMM-EPANET_User_Interface@noreply.github.com Cc: Paul Duda Paul.Duda@respec.com; Mention mention@noreply.github.com Subject: Re: [USEPA/SWMM-EPANET_User_Interface] Only set selected item if items exist (#346)

CAUTION: This email originated from outside of the organization. Exercise caution when viewing attachments, clicking links, or responding to requests.

@PaulDudaRESPEChttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PaulDudaRESPEC&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=yTOLC3a8K6CrV2kcLeXN3VKcYYLEoq_UyAsMfwDNFME&e= your check works for subcatchments but it seems like it makes it so you can't get a system report since there is nothing to select.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_USEPA_SWMM-2DEPANET-5FUser-5FInterface_pull_346-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DADGYURXMWXCO46HLHTKNMKLRAGZYTA5CNFSM4KM4CGKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKH7NOI-23issuecomment-2D579860153&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=Tt8HnoDI4PefkZcKb6EE8TrX8fiIfCLhQ6U_vrDwXog&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADGYURVYENAVKDTORY5MTQ3RAGZYTANCNFSM4KM4CGKA&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=wa2B1auxSPir6YJ66ZrI581fhFLn2GfLJx7tOnSXiEI&e=.

Confidentiality Notice: This E-mail and any attachments is covered by the Electronic Communications Privacy Act, 18 U.S.C. & 2510-2524, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, and permanently delete the original and destroy any copy, including printed copies of this email and any attachments thereto.

PaulDudaRESPEC commented 4 years ago

Thank you for pointing that out -- this is a more complete fix.

Paul

From: Paul Duda Sent: Wednesday, January 29, 2020 1:07 PM To: USEPA/SWMM-EPANET_User_Interface reply@reply.github.com Cc: Barr, Colleen Barr.Colleen@epa.gov Subject: RE: [USEPA/SWMM-EPANET_User_Interface] Only set selected item if items exist (#346)

Oops, I overlooked that! I’ll fix it…

From: Colleen Barr notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, January 29, 2020 12:08 PM To: USEPA/SWMM-EPANET_User_Interface SWMM-EPANET_User_Interface@noreply.github.com<mailto:SWMM-EPANET_User_Interface@noreply.github.com> Cc: Paul Duda Paul.Duda@respec.com<mailto:Paul.Duda@respec.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: Re: [USEPA/SWMM-EPANET_User_Interface] Only set selected item if items exist (#346)

CAUTION: This email originated from outside of the organization. Exercise caution when viewing attachments, clicking links, or responding to requests.

@PaulDudaRESPEChttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PaulDudaRESPEC&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=yTOLC3a8K6CrV2kcLeXN3VKcYYLEoq_UyAsMfwDNFME&e= your check works for subcatchments but it seems like it makes it so you can't get a system report since there is nothing to select.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_USEPA_SWMM-2DEPANET-5FUser-5FInterface_pull_346-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DADGYURXMWXCO46HLHTKNMKLRAGZYTA5CNFSM4KM4CGKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKH7NOI-23issuecomment-2D579860153&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=Tt8HnoDI4PefkZcKb6EE8TrX8fiIfCLhQ6U_vrDwXog&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADGYURVYENAVKDTORY5MTQ3RAGZYTANCNFSM4KM4CGKA&d=DwMCaQ&c=nqf85y6wts-2cjU4y4DXgA&r=g2H7jC2JKexzyKClRvKAgrkLY8MicTviykgJIlsPmDQ&m=ZHy75TmHNATpbtbfNdZvZUfgMTitZl8IkTNPpnq27NM&s=wa2B1auxSPir6YJ66ZrI581fhFLn2GfLJx7tOnSXiEI&e=.

Confidentiality Notice: This E-mail and any attachments is covered by the Electronic Communications Privacy Act, 18 U.S.C. & 2510-2524, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, and permanently delete the original and destroy any copy, including printed copies of this email and any attachments thereto.

barrc commented 4 years ago

Thanks @PaulDudaRESPEC, that seems to be working correctly.