Adding Calibration files causes program to crash

USEPA / SWMM-EPANET_User_Interface

User interface for the Stormwater-Management-Model

111 stars 66 forks source link

Adding Calibration files causes program to crash #404

Closed michelleannesimon closed 4 years ago

michelleannesimon commented 4 years ago

barrc commented 4 years ago

I can reproduce -- it crashes when I click 'OK' after selecting a file. I think it's crashing because self.file_dict is not defined at line 93 of frmCalibrationData. I haven't used calibration data much, so I'm not sure why the calibration file data is being stored in defaults.

barrc commented 4 years ago

In the Delphi GUI the calibration data is stored in the project-specific .ini file:

[Calibration]
File1=C:\Users\cbarr02\Desktop\climate_data_philly.dat
File2=
File3=
File4=
File5=
File6=
File7=
File8=
File9=
File10=
File11=
File12=

So I think the next step is looking at the project-specific .ini file for the new GUI.

michelleannesimon commented 4 years ago

I have had the same experience:

PaulDudaRESPEC commented 4 years ago

I think I fixed this issue with a commit moments ago, but I don't have very good calibration data to test with, so maybe @michelleannesimon you could test and verify this fixes the problem.

dickinsonre commented 4 years ago

So you want to have all types of calibration files? It would be best to test them all = I can supply them today or on Thursday.

dickinsonre commented 4 years ago

Here is the simple model and the calibration files that go with the simple model. Extran1_Egg.zip

PaulDudaRESPEC commented 4 years ago

Thanks, @dickinsonre . I'll test with these, and I'd also like to test with the same files that @michelleannesimon is attempting to use.

PaulDudaRESPEC commented 4 years ago

as per discussion with @michelleannesimon on 5/15/2020, this bug is now fixed