Remember geometry and state for SWMM frms

USEPA / SWMM-EPANET_User_Interface

User interface for the Stormwater-Management-Model

111 stars 67 forks source link

Remember geometry and state for SWMM frms #408

Closed barrc closed 4 years ago

barrc commented 4 years ago

This PR saves the geometry and state for many SWMM frms. I don't think it touches any EPANET frms.

I think this closes #302 but there may be something in the comment about defaults that we should open a new issue to track.

@fdumont7 please take a look when you get a change but please don't merge yet. There are a few more frms I would like to look at on Monday.

Frms that are not modified:

frmDetails (no OK or cancel button)
frmProfilePlot (something unknown going on)
frmQuery (not resizeable)
frmRunSWMM (appears irrelevant)

barrc commented 4 years ago

Faryn, Michelle, and I decided today to only save geometry/state if the user clicks OK. I pushed a commit that removes the saving if the user clicks Cancel.

Still going to look at some other forms so please don't merge yet.

barrc commented 4 years ago

I have not figured out how to make the frmMapDimensions geometry/state work. If Faryn has reviewed successfully, I think we should consider merging this as-is so we can see how this works in the course of normal testing and work from the dev-ui-py3qt5 branch. Then if we encounter any forms that were missed or are not behaving as expected, we can open new issues. What do you think @michelleannesimon and @fdumont7?

fdumont7 commented 4 years ago

@barrc everything has looked good to me, I'd be fine with merging it as it is now.

barrc commented 4 years ago

@fdumont7 thanks, I'm going to merge then.