search

USEPA / SWMM-GUI

Source Code for the Stormwater Management Model Graphical User Interface
4 stars 1 forks source link

Various 5.2.3 GUI issues #4

Closed MitchHeineman closed 10 months ago

MitchHeineman commented 1 year ago

The 5.2.3 GUI throws the error "Scrollbar property out of range" when a simulation exceeds 24855 days. This was not an issue in the past - I tested 5.1.015 just now and it worked fine for a 35,000-day simulation.

michaeltryby commented 1 year ago

Hey @MitchHeineman, we will certainly investigate this error. 35,000 days is approximately 96 years. Please pardon my ignorance, but what is the objective behind such a long period of simulation? Thanks!

MitchHeineman commented 1 year ago

You caught me - we're using the Hargreaves method in SWMM to generate a PET timeseries for long-term reservoir modeling using other software. Although I have done 70-y hydrologic simulations in SWMM where we run hydrology that includes explicitly modeled groundwater infiltration and selectively simulate hydraulics during principal storms using the [EVENTS] feature.

LRossman commented 1 year ago

There are several other GUI bugs in v5.2.3 that I'd like to report here (since this repository is focused on the SWMM engine and not its GUI I thought it better to list GUI bugs within a single issue rather than intersperse them amid engine issues):

  1. The Study Area Map flickers as one pans across it (this was not the case in prior releases).
  2. After opening an input file created prior to release 5.2.2 an Access Violation error will occur if one tries to give a Storage Unit node a polygon shape by using the vertex editor.
  3. When re-opening the Welcome Screen (from the Help menu) and selecting a file from it to open, the user is not prompted to save changes made to the current project they were working on.
  4. The routine used to find the centroid of subcatchment and storage node polygons is missing an initialization causing it to fall back to use a simpler algorithm that might place the centroid outside of the polygon (the fix is to add V = First at line 362 of the Uvertex.pas file).
  5. The Max/Full Depth values for orifices and weirs appear in the wrong column of the Summary Results Link Flow table.
michaeltryby commented 1 year ago

@LRossman Thank you!

MitchHeineman commented 1 year ago

I think Lew's item 2 is the same as https://github.com/USEPA/Stormwater-Management-Model/issues/105

LRossman commented 10 months ago

The scrollbar problem has been fixed in release 5.2.4 so this issue should be closed.