`sc_get_data` reversed args for showAreaSqKm, showPctFull

USEPA / StreamCatTools

R package to work with the StreamCat API within R and access the full suite of StreamCat catchment and watershed scale metrics for all NHDPlusV2 stream reaches and catchments.

https://usepa.github.io/StreamCatTools/

Creative Commons Zero v1.0 Universal

30 stars 6 forks source link

`sc_get_data` reversed args for showAreaSqKm, showPctFull #27

Closed daauerbach closed 1 year ago

daauerbach commented 1 year ago

Loving this package. I noticed today that the lines building the POST request have swapped the arguments for percent full and area. Easy workaround for me, and/but should be an easy fix in a next round of dev?

https://github.com/USEPA/StreamCatTools/blob/5800a43f13414f86ed4f7d3f912c24b0acfd54bc/R/sc_get_data.R#L79

mhweber commented 1 year ago

@daauerbach - good to hear and sorry for slow response to this! I'll roll this into couple round of fixes / tweaks that need to be made - thanks for pointing out!

mahonmb commented 1 year ago

Following up on this; I noticed there is also an issue in the same set of post_body code, where count_only is swapped for conus: post_body <- paste0(post_body, "&countOnly=", conus).