Censored Data tab bug

[cristinamullin]

Describe the bug

If a user clicks "Apply Methods to Dataset" more than once... the method is applied over and over.

For example, Non-Detect Handling Method = Multiply detection limit by x Multiplier (x) = 0.5 Over-Detect Handling Method = No change then each time the sum reduction = ½ ½ ½.

Also, multiple different methods can be applied now which does not make sense. A user must only select one, and then undo the method if they want to select and apply a different one after reviewing the table.

To Reproduce

Use any dataset and go to the censored data tab, click the "Apply Methods to Dataset" button more than once and observe.

Expected behavior

The "Apply Methods to Dataset" button should only be able to be clicked once. After that, the button should disappear or maybe turn grey. If a user wants to undo the method they can click the "Undo Method Application" button. If they click that, they the "Apply Methods to Dataset" should be made available again.

Screenshots

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

• [ ] Create the function/code.

• [ ] Document all code using comments to describe what is does.

• [ ] Create tests.

[JamesBisese]

For the first part, I need to disable the select button after it has been applied once. This is done locally.

    # Button to apply the simple methods to the nd and od results in the dataset.
    shiny::observeEvent(input$apply_methods, {
      shinybusy::show_modal_spinner(
        spin = "double-bounce",
        color = "#0071bc",
        text = "Applying selected methods...",
        session = shiny::getDefaultReactiveDomain()
      )
      # disable the button so the user can not redo the handling
      shinyjs::disable("apply_methods")

still to do is toggle it back on if 'undo_methods' is hit.

[JamesBisese]

I added an 'enable' line, but now see that once you run the apply_method the first time you also have to disable to multiplier field because if you change that and then 'undo' it uses the new value and you can't get back to where you started.

This is what I added to the shiny::observeEvent(input$undo_methods

      # (re)enable the button so the user can redo the handling
      shinyjs::enable("apply_methods")
      shinyjs::enable("nd_mult")