search

USEPA / TADAShiny

TADAShiny is a DRAFT R Shiny application (link to web version below) built on top of the TADA R Package (https://github.com/USEPA/TADA). It provides a user friendly, web accessible interface.
https://rconnect-public.epa.gov/TADAShiny/
Creative Commons Zero v1.0 Universal
11 stars 4 forks source link

Censored Data tab will crash if no Multiplier (x) is provided before a user hits apply #173

Open cristinamullin opened 1 week ago

cristinamullin commented 1 week ago

Describe the bug

Censored Data tab will crash if no Multiplier (x) is provided (left NA) before a user hits apply.

To Reproduce

Steps to reproduce the behavior:

  1. open app in R studio and load any data (I used the Nutrients UT example dataset)
  2. skip to flag tab and run tests
  3. skip to Censored Data tab, scroll down and remove 0.5 (default value) from Multiplier (x). Hit "Apply Methods to Dataset". The app will crash.
Error: (converted from warning) Error in if: missing value where TRUE/FALSE needed

Expected behavior

The app should not crash. Instead, a message should pop up reminding the user to populate Multiplier (x) with a value.

Screenshots

image
JamesBisese commented 6 days ago

The Apply Methods to Dataset should not be active if there is no value in the Multiplier (x) field.

I will disable the Apply Methods to Dataset button until the Multiplier (x) is entered. This will take about 1 hour