USEPA / camd-eia-crosswalk

A data crosswalk to integrate U.S. power sector emission and operation data from EPA to EIA
MIT License
34 stars 11 forks source link

update manual_matches #25

Open grgmiller opened 2 years ago

grgmiller commented 2 years ago

This PR updates manual matches to add multiple crosswalks that were missing, and add several additional unit exclusions that are listed in Table 4-2 of eGRID 2020, but were not included in the crosswalk. I also fixed one plant ID mapping for CAMD_PLANT_ID 55248, which should be matched to EIA_PLANT_ID 2847.

Some of these missing crosswalks might be fixed if the R script were run using 2020 EIA-860 data.

grgmiller commented 2 years ago

I'll note that I was unable to test how these updates affect the end result because I mostly code in Python and was unable to get R running on my machine easily.

grgmiller commented 1 year ago

@j-tafoya @jeremy-schreifels I just wanted to flag this for review.

j-tafoya commented 1 year ago

Hi @grgmiller, thank you for the contribution! We're in the final stages of preparing the next release that adds several manual matches and many of them may overlap with the ones you added. We will review these as we do our final QA. You should see the new release soon!

grgmiller commented 1 year ago

Awesome, thanks!

grgmiller commented 1 year ago

Thanks for the update @j-tafoya - we appreciate all of your team's work on this! Out of curiousity, why not update the crosswalk to incorporate 2020 data at this point? Is it just that adding new years of data requires additional manual work? What do you think the timing for the more recent data year update might be? I know that 2021 EIA data will be released soon - do you think your update will include 2021 data as well?

grgmiller commented 1 year ago

Hi @j-tafoya I noticed that v0.3 does not include the updated mapping for CAMD_PLANT_ID 55248 to EIA_PLANT_ID 2847 even though this mapping is included in the eGRID documentation. Should we be treating eGRID as the correct source, or the Power Sector Data Crosswalk?

image

image image

j-tafoya commented 1 year ago

Hey @grgmiller, please see our answer here in the discussion area that may address these questions.