search

USEPA / e-manifest

API services documentation and reference material for the e-Manifest hazardous waste tracking system
https://www.epa.gov/e-manifest
Creative Commons Zero v1.0 Universal
26 stars 22 forks source link

PEP 8 naming compliance? Discussion #1517

Closed dpgraham4401 closed 1 year ago

dpgraham4401 commented 1 year ago

Should we change the names of the RcraClient method to be PEP 8 compliant before releasing version 3.0?

I'm not a 'must-be-PEP-8-compliant' nut, but it's worth examining. I'm thinking this is likely the last major release of the emanifest PyPi package, so if we're goin to change it, now is the time (and it's not really difficult to do).

wiljnichepa commented 1 year ago

I'm not a purist either, but if we're already going to make some breaking changes as part of a big release we might as well throw everything in. It will be the last major release for a while at least. The launch of V2 services at some point would definitely be a 4.0 release in my mind

dpgraham4401 commented 1 year ago

Do we have a timeline, and, more importantly what changes are going to be introduced with the V2 revisions? There may be ways we can make emanifest 3.0 more flexible to accommodate the future changes.

Also cool, about PEP 8. Agreed that we might as well.