search

USEPA / e-manifest

API services documentation and reference material for the e-Manifest hazardous waste tracking system
https://www.epa.gov/e-manifest
Creative Commons Zero v1.0 Universal
26 stars 22 forks source link

Clean up RcrainfoClient API and remove new client #1533

Closed dpgraham4401 closed 1 year ago

dpgraham4401 commented 1 year ago

This PR marks the final installment of our emanifest 3.0 improvement series.

It cleans up the API (open to opinions and modifications) via getters and setters (@properties), removes the new_client function, and updates the docs (README.md).

After this, we should be ready (or getting close barring any additional backwards incompatible changes we'd like to make before release) to release version 3.0.

The Publish to PyPI workflow should only run on merged PR to master when pyproject.toml has changed (assuming our master branch has some branch protection rules, should be OK even without)

closes #1530 closes #1531

dpgraham4401 commented 1 year ago

@scottdchristian @wiljnichepa

I'd like to keep the emanifest PyPI package API pretty stable after 3.0 release (Sorry users of the 2.0), y'all have any ideas you'd like to see implemented in this package before we release 3.0?

wiljnichepa commented 1 year ago

I think this looks great - I will review in depth this week and have full comments by Friday.

scottdchristian commented 1 year ago

Yes I will plan on looking too. Thanks for asking!