search

USEPA / elevatr

An R package for accessing elevation data
Other
204 stars 26 forks source link

add gdal mosaic for faster merge/project #34

Closed mikejohnson51 closed 4 years ago

mikejohnson51 commented 4 years ago

Hi Jeff,

As discussed here is a pull request for speeding up raster merging. The following has been done:

  1. add function called merge_rasters and adjusted get_aws_terrain and get_elev_raster accordingly
  2. modified clip_it to reference raster CRS (since projection is done while merging)
  3. change projections in tests to reflect the gdal exports
  4. Run devtools build, document, check
  5. Ensure all tests pass

I have a few ideas about getting rid of the CRS warnings stemming from the new PROJ libraries/rgdal but it might be a more "invasive" moving from sp to sf. Please let me know if you are interested in that (completely understand if not 😄 )

I learned a lot looking at your code and process. Thanks for the opportunity and hope this is useful!

Mike

jhollist commented 4 years ago

@mikejohnson51 Looks good! Go ahead and add yourself as a ctb in the DESCRIPTION and push that commit. Once that is up, I'll merge.

Thanks!

jhollist commented 4 years ago

Looks good.. Merging now.

mikejohnson51 commented 4 years ago

Thanks for letting me contribute! Its a great package