search

USEPA / elevatr

An R package for accessing elevation data
Other
203 stars 26 forks source link

adds some suggestions #88

Closed Nowosad closed 1 year ago

Nowosad commented 1 year ago

OpenGeoHub summer school 2023 work:

  1. Fixes a few typos
  2. Updates bib style (new CRAN requirement)
  3. Hides .devcontainer
  4. Hides one test (that requires API)

Also @jhollist -- I would suggest renumbering the version to, e.g., 0.99 or just completely switch to SpatRaster and use 1.0.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -9.40% :warning:

Comparison is base (2849667) 84.07% compared to head (e374425) 74.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================== - Coverage 84.07% 74.67% -9.40% ========================================== Files 4 4 Lines 383 383 ========================================== - Hits 322 286 -36 - Misses 61 97 +36 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/jhollist/elevatr/pull/88/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeffrey+W+Hollister)

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

jhollist commented 1 year ago

@Nowosad Thanks for this and sorry for delay in responding. Just got back from vacation this week and have finally dug out of most of the pile. I'll take a look at this today/tomorrow. I also really like the versioning suggestion.

Nowosad commented 1 year ago

👍🏻