button mnemonic conflict / remove Edit from Revisions tab in view mode?

[cseppan]

When viewing a dataset's properties, the Revisions tab has an Edit button. The mnemonic for this button (E) conflicts with the Edit Properties button that's part of the window. 'I' or 'T' are available for changing the mnemonic, but should this Edit button be here at all?

[eyth]

Isn't this for editing a revision? Yes we could call it something else if needed.

On Wed, Aug 11, 2021 at 5:38 PM Catherine Seppanen @.***> wrote:

When viewing a dataset's properties, the Revisions tab has an Edit button. The mnemonic for this button (E) conflicts with the Edit Properties button that's part of the window. 'I' or 'T' are available for changing the mnemonic, but should this Edit button be here at all?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/USEPA-OAQPS/emf/issues/66, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26PS7YXL5JG3JTA2BXORDT4LUWPANCNFSM5B7RIYLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

[cseppan]

Specifically, this is a problem when viewing the dataset's properties, not editing. All the other tabs don't have the Add or Edit buttons when you're only viewing.

[eyth]

Oh right - thanks for clarifying... Agreed it shouldn't be Edit from the View properties window

On Wed, Aug 11, 2021 at 6:02 PM Catherine Seppanen @.***> wrote:

Specifically, this is a problem when viewing the dataset's properties, not editing. All the other tabs don't have the Add or Edit buttons when you're only viewing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/USEPA-OAQPS/emf/issues/66#issuecomment-897190794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26PS3XBKZGV37WQEK7HILT4LXQRANCNFSM5B7RIYLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

[cseppan]

Commit ce9571d8f24d42cca08c3f44f5123ca947ea16fd removes the Edit button when the Revisions tab is displayed in the Dataset Properties Viewer window. The Revisions Edit button is still available in the Dataset Properties Editor window.