USEPA / emf

Emissions Modeling Framework (EMF)
6 stars 3 forks source link

check truncation in revisions list #89

Closed cseppan closed 2 years ago

cseppan commented 2 years ago

From Alison:

I was actually using the EMF for a few things and I noticed it would be helpful to not truncate the revision info so much in the tables. Here is a picture. Are we cutting these off at a specific number of characters? If so, an we maybe double or triple the cutoff? It would be helpful to see more context on this tab and I’m guessing it would be a quick fix. This cutoff may also hinder the screen reader as it reads the table?

image001

cseppan commented 2 years ago

The truncation is explicitly set to 25 characters.

https://github.com/USEPA-OAQPS/emf/blob/72b63f874adb178d1c0a8c5bdd0e875294ef1659/EMF/src/client/gov/epa/emissions/framework/client/meta/revisions/RevisionsRowSource.java#L17-L25

Without any truncation, the columns are automatically as wide as needed to show all the text.

Screen Shot 2021-09-15 at 11 37 25 PM

It doesn't look like there's any option to explicitly set column widths in the underlying Sort-Filter-Select table. For now, I'll bump the truncation length up to 50 characters to show more text but also keep the default column widths manageable.

Screen Shot 2021-09-15 at 11 45 23 PM