search

USEPA / esupy

A library supporting Python-based tools in USEPA's tool ecosystem
5 stars 2 forks source link

Add confirm to make url request() #25

Closed matthewlchambers closed 2 years ago

matthewlchambers commented 2 years ago

When downloading a large file from Google drive, a confirmation token must be read form the first response's cookies and then resubmitted as a parameter. This enables that functionality. It also makes the old set_cookies parameter and the new confirm_gdrive parameter keyword only so that there can't be any confusion in the future about what is being set to True/False. This does not require any changes to other files in the esupy/flowsa/stewi ecosystem, since the only time the set_cookies argument was supplied, it was supplied by keyword.

bl-young commented 2 years ago

@matthewlchambers I'm trying to make sure I'm understanding keyward arguments correctly (this is helping). Both for this and for the recent PR In flowsa.

matthewlchambers commented 2 years ago

@matthewlchambers I'm trying to make sure I'm understanding keyward arguments correctly (this is helping). Both for this and for the recent PR In flowsa.

Sounds good! Let me know if there are any adjustments you want me to make.

catherinebirney commented 2 years ago

@bl-young thanks for that link. These changes look fine to me. Out of curiosity, @matthewlchambers what data is hosted on google drive?

matthewlchambers commented 2 years ago

@catherinebirney The EQUATES data are hosted on Google drive.