search

USEPA / fedelemflowlist

MIT License
34 stars 21 forks source link

Unexpected mis-matched flows in eLCI.csv #200

Open dt-woods opened 4 days ago

dt-woods commented 4 days ago

In the latest eLCI model inventories (e.g., solar, solarthermal, wind), emissions are already mapped to the FEDEFL, which is causing our flow mapping to fail. For example, '1,3-Butadiene' does not match any source flows in eLCI, but matches a target flow.

https://github.com/USEPA/fedelemflowlist/blob/7f2550a383a026ade3d23c8b0e3f6d1ba411bdd3/fedelemflowlist/flowmapping/eLCI.csv#L1206

The result is that mapped flows are being dropped from our inventories.

It would be nice if all the mapped FEDEFL flows were also listed in the sources (i.e., no change; map to itself). If there is an alternative recommendation to updating the CSV, I'm happy to take suggestions.

bl-young commented 17 hours ago

Can you remind me where this is done in the code? I think it could make more sense to pull out the flows in the dataframe which are already in the FEDEFL or have UUID's and only map the remaining? rather than change the mapping file to try to map flows to itself