USEPA / flowsa

Library that attributes resource use, waste, emissions, and loss to economic sectors
MIT License
23 stars 19 forks source link

update recursive-refac with sector_mapping (includes up-to-date develop branch) #330

Closed catherinebirney closed 1 year ago

catherinebirney commented 1 year ago

relevant to recursive-refac:

relevant updates from master:

catherinebirney commented 1 year ago

@matthewlchambers checks are now passing for all FBS. I modified SEEA_2017_kg_v1 to drop a comma that broke the code. Take a look at modifications to update map_to_sectors() and let me know if you see any issues.

catherinebirney commented 1 year ago

I think this should all be basically fine, noting that I haven't tested all the additions to flowby.py. Also, in the recursive branch I don't think flowbysector.py is getting used much if at all, so I hope that the changes to flowbysector.py are accomplishing their intended goal.

@matthewlchambers I updated sector_mapping with the most recent changes to develop/master branches, so the changes in flowbysector.py are not applicable to the recursive code.

Thanks for the review - I will go ahead and merge