Closed catherinebirney closed 1 year ago
@matthewlchambers in my update of mapping source_naics to target_naics I did include the option of including non_naics (e.g., "non_naics: ACC") but I didn't quite understand what was happening originally so I'm not sure I included it correctly and I'd appreciate if you would check that the non_naics map correctly
@matthewlchambers in my update of mapping source_naics to target_naics I did include the option of including non_naics (e.g., "non_naics: ACC") but I didn't quite understand what was happening originally so I'm not sure I included it correctly and I'd appreciate if you would check that the non_naics map correctly
Yep, I'll check that! I like this, it's much smoother than what I had before!
I really love the new crosswalk, and the use of melt
! This is sooo much easier to follow than what I had before, in addition to being more robust.
I just pushed 3 commits to this branch, making the following minor changes:
industry_spec
and updates target_naics
to make the logic a little simpler.non_naics
to make it clearer than my original version and (incidentally) allow the user to specify a list of non-NAICS codes if needed.Looks good, thanks @bl-young and @matthewlchambers. I will merge.