search

USEPA / flowsa

Library that attributes resource use, waste, emissions, and loss to economic sectors
MIT License
23 stars 19 forks source link

Github Action Generate FBS Timeout #377

Closed catherinebirney closed 10 months ago

catherinebirney commented 1 year ago

We are generating too many FBS for the github action Generate FBS so the action fails when it times out

We need to revise the action - either drop some of the more time-intensive FBS or modify the code in another way

@bl-young

bl-young commented 1 year ago

I think my original commit https://github.com/USEPA/flowsa/commit/0c5212322cae947392eabe80c2fe20286009f649 did that, but in the wrong function. Would replicating that for Generate FBS work as well?

catherinebirney commented 1 year ago

The idea behind this function was to generate all FBS so we could upload those to Data Commons. But I generally run all the FBS locally because I generate new FBAs and this function downloads the FBAs from DC. Is it worth keeping this function? I'd be fine with deleting it, since our other FBS function that you revised checks that our methods work.

bl-young commented 1 year ago

yep agreed - probably not necessary

catherinebirney commented 10 months ago

We deleted generate_FBS.yml with b79df8f- this change will be pulled into master with the flowsa2.0 release