search

USEPA / flowsa

Library that attributes resource use, waste, emissions, and loss to economic sectors
MIT License
23 stars 19 forks source link

Error in green space ratio function #384

Closed matthewlchambers closed 8 months ago

matthewlchambers commented 11 months ago

The get_US_urban_green_space_and_public_parks_ratio function in literature_values.py contains a try . . . except block that tries to catch a ZeroDivisionError. However, this error cannot be raised by the try block, since the try block only defines a function and doesn't actually do any division. Therefore, the desired behavior in the case of zero division will not occur.

catherinebirney commented 11 months ago

thanks @matthewlchambers - I'll look into this today

catherinebirney commented 10 months ago

@matthewlchambers Are you planning on using this data/function? Or is this a bug that you noticed and are flagging? I do not use that function in the land attribution method anymore, so I can delete it

catherinebirney commented 8 months ago

conclusion - delete fxn