USEPA / flowsa

Library that attributes resource use, waste, emissions, and loss to economic sectors
MIT License
23 stars 19 forks source link

updates to flowsa metadata #399

Closed catherinebirney closed 8 months ago

catherinebirney commented 8 months ago
catherinebirney commented 8 months ago

@bl-young Once the checks complete I'd like to pull this PR into master to check the new compare FBA github action is working correctly

bl-young commented 8 months ago

You can also commit .github/workflows/compare_single_FBA.yml by itself directly to master and then test on this branch without pulling everything else in first

catherinebirney commented 8 months ago

You can also commit .github/workflows/compare_single_FBA.yml by itself directly to master and then test on this branch without pulling everything else in first

That is a better idea, I will do that, thanks!

catherinebirney commented 8 months ago

@bl-young The new github action works. I am done with changes on this branch, so this PR is ready to be pulled in

bl-young commented 8 months ago

Awesome - any ideas of an FBA that has changed that we could test this on? Nothing immediate comes to mind for me.

catherinebirney commented 8 months ago

I locally tested on FBAs that have changed - Census_PEP_Poplulation changed between v1.3.0 and v2.0.0 but there won't be any differences in the FBAs flowsa creates right now vs what is on data commons, so you would need to download those files

catherinebirney commented 8 months ago

yes, thanks - I added the source pub date to FBA metadata json. I'll pull this in when the checks are done