search

USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats
https://usepa.github.io/harmonize-wq/
MIT License
12 stars 5 forks source link

u_reg used for convert decorators #42

Open jbousquin opened 12 months ago

jbousquin commented 12 months ago

Currently one standard unit registry is used by the conversion decorators. This needs to either be passed in (potentially by another decorator?) or the u_reg needs to have all additions for all expected units. Currently just has 'TODO: find more elegant way to do this with all definitions'

jbousquin commented 7 months ago

Currently uses domains.registry_adds_list() for turbidity and salinity (includes pct_list). The only definitions from registry_adds_list() not added to the decorator u_reg is bacteria_list, and none of those have existing conversion functions in convert module.

This could be made more expandable.