search

USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats
https://usepa.github.io/harmonize-wq/
MIT License
12 stars 5 forks source link

Py open sci review #56

Closed jbousquin closed 4 months ago

jbousquin commented 5 months ago

Start to address Editor review

jbousquin commented 4 months ago

5/388 example tests break docs build (expected with functions moving between modules):

  1. harmonize.add_qa_flag(df, mask, flag) in clean.py
  2. harmonize.df_checks(df, columns=['CharacteristicName']) in clean.py
  3. harmonize.df_checks(df, columns=['ResultMeasureValue']) in clean.py
  4. harmonize.convert_unit_series(quantity_series, unit_series, units = 'mg/l') in convert.py
  5. harmonize.units_dimension(unit_series, units='mg/l') in wq_data.py
jbousquin commented 4 months ago

Removes cyclic modular-level references