USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats
https://usepa.github.io/harmonize-wq/
MIT License
12 stars 5 forks source link

Review edits - Harmonize_Pensacola.Rmd #62

Closed jbousquin closed 2 months ago

jbousquin commented 4 months ago

-Small language changes suggested to make the installation process more user-friendly and clear: -make it clear when something is an option to run and when it's step-by-step instruction, as it switches back an forth in this demo. For example, could add "# Install the harmonize-wq package... [#option 1] package install... [#option 2] development version..." -Clearer separation of code chunks by task, so each code chunk focuses on a specific task. This makes debugging/error message interpretation easier. Ie a new code chunk after options(reticulate.conda_binary = "..."), new code chunks after conda_install() section (lines 72, 81). (For good examples see the .ipynb demo files for this package). -I think use_condaenv("wq_harmonize") should be use_condaenv("wq-reticulate") (line 90)