Closed rcaneill closed 2 months ago
cf #64 The instructions should probably be:
# install
pip install -e .
pip install -r requirements.txt
pip install -r requirements_dev.txt
# run the tests
pytest harmonize_wq
Hi @rcaneill - This (pip install from requirements_dev) was added to the docs contributing page on the pyOpenSci-review branch. Once that is passing, merged and the docs built does it seem adequate to close this issue?
It's good to see it somewhere. However, I believe that "explicit is better than implicit", and so providing the exact commands to type should be done, as in https://github.com/USEPA/harmonize-wq/issues/63#issuecomment-2074401601
I can open a PR for that, or let you do it (or if you disagree please tell me why)
Hi, I am starting my in-depth review and will open issues with my questions / comments on the fly.
I believe that the package is missing some instructions for devs, like:
Here is what I did, I guess it is what should be done: