search

USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats
https://usepa.github.io/harmonize-wq/
MIT License
12 stars 5 forks source link

Review RC: tests not passing #64

Closed rcaneill closed 4 months ago

rcaneill commented 4 months ago

The tests are failing on my laptop with Python 3.8, on the branch new_release_0_4_0. This is weird as I see that the GH action succeeded... I'll investigate this and maybe even close this issue very soon

FAILED harmonize_wq/tests/test_harmonize_WQP.py::test_harmonize_pH - AssertionError: assert nan == 'None'
FAILED harmonize_wq/tests/test_harmonize_WQP.py::test_harmonize_nitrogen - AttributeError: 'float' object has no attribute 'upper'
FAILED harmonize_wq/tests/test_harmonize_WQP.py::test_print_report - ImportError: matplotlib is required for plotting when the default backend "matplotlib" is selected.
ERROR harmonize_wq/tests/test_harmonize_WQP.py::test_harmonize_all - AttributeError: 'float' object has no attribute 'upper'
ERROR harmonize_wq/tests/test_harmonize_WQP.py::test_conductivity_to_PSU - AttributeError: 'float' object has no attribute 'upper'
ERROR harmonize_wq/tests/test_harmonize_WQP.py::test_datetime - AttributeError: 'float' object has no attribute 'upper'
ERROR harmonize_wq/tests/test_harmonize_WQP.py::test_split_col - AttributeError: 'float' object has no attribute 'upper'
ERROR harmonize_wq/tests/test_harmonize_WQP.py::test_split_table - AttributeError: 'float' object has no attribute 'upper'
rcaneill commented 4 months ago

Ok I did pip install -r requirements.txt and now the tests pass. See #63 that could sort this issue. Closing as complete.