search

USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats
https://usepa.github.io/harmonize-wq/
MIT License
12 stars 5 forks source link

RC review: add jupyter as it is needed for doc #71

Closed rcaneill closed 1 month ago

jbousquin commented 2 months ago

Agree jupyter notebooks are needed for demos. Moving from notebooks to jupyterlabs as suggested will take some further investigation but I'm not opposed.

jbousquin commented 2 months ago

I had a chance to dig into this - jupyterlab doesn't have much additional dependencies but a couple of conda env builds seemed to have issues where the same env with notebook was fine. If there is a compelling reason for labs over notebooks I can try to resolve those but otherwise tempted to stick with what works.

rcaneill commented 1 month ago

I believe that you could stick to notebook instead of jupyterlab, but I don’t see it in the requirements-dev.txt