RC review: Lock test file with commit instead of master

USEPA / harmonize-wq

Standardize, clean, and wrangle Water Quality Portal data into more analytic-ready formats

https://usepa.github.io/harmonize-wq/

MIT License

12 stars 5 forks source link

RC review: Lock test file with commit instead of master #72

Closed rcaneill closed 1 month ago

rcaneill commented 3 months ago

I believe that providing the exact version of the test file may avoid problems in the future if the upstream Coastal_Ecological_Indicators is updated

jbousquin commented 2 months ago

I don't disagree, but my preference is to keep it standard for all the example files in this package and point to the main/master rather than the commit. (1) I'm the owner/maintainer of the other repo and don't anticipate changes to this file, and (2) I've seen others and been burned myself by github urls changing - if that happens generally I'm more aware, my concern would be that something would change for commits and being non-standard it would be harder to detect.

rcaneill commented 1 month ago

Ok sounds fair, I close this PR