search

USEPA / sc-hfc

MIT License
0 stars 2 forks source link

MimiIWG Dependency on ExcelReaders #1

Open lrennels opened 2 years ago

lrennels commented 2 years ago

Hi @bryanparthum, I wanted to let you know that some users (@tammyt123 included) have noticed some warnings, and crashes on Linux, due to MimiIWG depending on ExcelReaders for reading .xls files. This is a known problem, and there is not currently a great solution for reading that file type within Julia. Previously I had not seen crashes due to the problem, instead just warnings but correct behavior and tests passing, but now it does seem to be a breaking problem at least on Linux.

I am going to tag a new version of MimiIWG that converts input files from .xls to .xlsx and .xlsm, and removes the dependency on ExcelReaders here. I can then update this repository to depend on that updated version of MimiIWG, and we will be rid of these issues.

No action needed on your part, just letting you know. We can do the same to the repo here: https://github.com/bryanparthum/MimiIWG-HFC if you want that one to stay up to date although I assume the goal is for this to be the current version.

bryanparthum commented 2 years ago

Super. You are correct, this repo will remain the standing replication for the AIM Act SC-HFCs. The previous will no longer be maintained. Thanks!