USEPA / standardizedinventories

Standardized Release and Waste Inventories

MIT License

25 stars 16 forks source link

stewicombo removing records where FRS_ID is null #20

Closed WesIngwersen closed 5 years ago

WesIngwersen commented 5 years ago

e.g.

! beware long run time

inventories_of_interest = {'eGRID': '2016', 'TRI': '2016', 'NEI': '2016', 'RCRAInfo': '2015'} emissions_and_wastes_by_facility = stewicombo.combineInventoriesforFacilitiesinOneInventory("eGRID",inventories_of_interest,filter_for_LCI=True) len(emissions_and_wastes_by_facility[emissions_and_wastes_by_facility['FRS_ID'].isnull()])

0 Null for FRS_ID removed

This should not be the case for eGRID where not all facilities have SRS_IDs

WesIngwersen commented 5 years ago

Found the problem in getInventoriesforFacilityMatches The function should have taken 'base_inventory' and not 'base_inventory_FRS'

WesIngwersen commented 5 years ago

Resolved in this commit